Bug 4516 - 'Message Scroll' menu items don't work when viewing 'text/html' part
Summary: 'Message Scroll' menu items don't work when viewing 'text/html' part
Status: REOPENED
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: Plugins/Fancy (show other bugs)
Version: 4.0.0
Hardware: PC Linux
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2021-08-08 12:36 UTC by Dustin
Modified: 2023-12-17 05:24 UTC (History)
1 user (show)

See Also:


Attachments

Description Dustin 2021-08-08 12:36:28 UTC
When using the 'Fancy' plugin to view an email's HTML part (either in message view or by opening it in a new window), keyboard navigation doesn't work as expected/desired, whereas it does when viewing 'message/rfc822' and 'text/plain' part types.

Steps to Reproduce:

1) Build/Install Claws Mail 4.0.0 from the tarball release with 'Fancy' plugin support, then start CM and load the plugin.

2) View the 'text/html' part of an email that has one, either in message view or by opening in a new window.

3) Try to use the keyboard to scroll up and down in the email as you would when viewing a different email part (i.e. space bar, Enter, etc., or hotkeys you've assigned to the menu items in 'View - Message Scroll'.). (Switch to the 'message/rfc822' or 'text/plain' parts and try the same thing to note the difference.)

Actual Results: No response to keyboard inputs.

Workarounds:
* 1) The mouse can be used with the scroll bar.
* 2) If you manually put the focus on the message view, then the up/down arrows and PgUp/PgDwn keys will work, although this doesn't work when the message is opened in a new window. However, this workaround does not result in hotkeys assigned to the menu items in 'View - Message Scroll' working.)

Expected Results: The message will move up and down according to keyboard inputs, consistent with how it does when viewing the 'message/rfc822' or 'text/plain' parts.

This is basically just a rewrite of the same bug I filed for the 'LiteHTML Viewer' (Bug 4247: https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4247). The bug was showing as open (aka 'NEW'), but this has been fixed and working for me for quite awhile, so I went ahead and changed its status to 'RESOLVED' / 'FIXED'. I've also confirmed that the 4.0.0 version of this plugin also works as expected. I mention this in case this plugin's code could be used as a reference to provide this same enhancement for 'Fancy'.

For my current usage, I am mainly interested in keyboard usage with hotkeys assigned to the menu items in 'View - Message Scroll'. However, for those who are interested in keyboard usage with the 'default' space-bar and 'Enter' keys, then I'm guessing this bug has some overlap with Bug #4503 (https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4503).
Comment 1 Paul 2021-08-08 13:52:08 UTC
Thr problem here is that the html view does not automatically have the focus. You need to use the TAB key to move the focus to it first.
Comment 2 Paul 2021-08-08 13:52:45 UTC

*** This bug has been marked as a duplicate of bug 4503 ***
Comment 3 Dustin 2021-08-08 14:44:02 UTC
As I mentioned in my bug report, what you note in Comment 1 will work for some types of keyboard navigation, but not for all.

Just to confirm, did you try the steps to reproduce that I posted? If so did you get the same or a different result than I did? If different, I would be interested to know, since it may indicate that I need to look outside of Claws for a solution. If the same, would you consider re-opening this?

Based on my experience with this, I believe that the 'focus' bug is possibly / probably related to this in some way, but I don't think fixing that will solve the problems I am facing; that is why I don't believe this is a duplicate and why I filed it as a separate bug.
Comment 4 Dustin 2021-08-08 14:50:50 UTC
To make my experience a bit more clear in relation to what to test for a potential 'non-focus' issue, even if I use the 'Tab' key or my mouse to put focus on the message view, there is still no response when I use the menu items under 'View - Message Scroll', whether via the menu or via keyboard hotkeys associated with those items. These, however, do work as expected for the other email parts mentioned.
Comment 5 Paul 2021-08-08 15:01:59 UTC
Right. Sorry. You were too wordy to get your point the first time.
Comment 6 Dustin 2021-08-09 08:55:04 UTC
(In reply to Paul from comment #5)

No problem, Paul. I realize now I could have been more focused and concise by leaving out whatever was potential overlap with Bug 4503, but it looks like I can't edit the description. I've changed the summary, and here's an edited version in case it's helpful for you or others who are following:

"When using the 'Fancy' plugin to view an email's 'text/html' part, the 'View - Message Scroll' menu items don't work, whereas they do when viewing the same email's 'message/rfc822' and 'text/plain' parts.

"Steps to Reproduce:

"1) Build/Install Claws Mail 4.0.0 from the tarball release with 'Fancy' plugin support, then start CM and load the plugin.

"2) View the 'text/html' part of an email.

"3) Try to use the 'View - Message Scroll' menu items to scroll up and down in the email. (Switch to the 'message/rfc822' or 'text/plain' parts and try the same thing to note the difference.)

"Actual Results: The message does not move. (Note that this is the same whether the message view has the focus or not.)

"Expected Results: The message will move up and down according to respective menu items used.

"(This is a similar bug to one I filed for the 'LiteHTML Viewer' (Bug 4247: https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4247), which has since been fixed. I've also confirmed that the 4.0.0 version of this plugin works as expected. I mention this in case this plugin's code could be used as a reference to provide the same enhancement for 'Fancy'.)"

Thanks for considering my request; I appreciate your time on this.
Comment 7 Paul 2021-08-18 10:10:40 UTC

*** This bug has been marked as a duplicate of bug 4503 ***
Comment 8 Dustin 2021-08-18 11:37:37 UTC
(In reply to Paul from comment #7)

So am I right in assuming that you've confirmed that the same problem in the code is causing both of the seemingly different issues in this bug and bug 4503, such that fixing the problem in the code will resolve both bugs?
Comment 9 Paul 2021-08-18 11:44:04 UTC
no. closing it as a duplicate was a mistake
Comment 10 Dustin 2021-08-18 12:58:43 UTC
(In reply to Paul from comment #9)

Got it; thanks for the confirm.
Comment 11 Dustin 2023-12-17 05:24:09 UTC
I've confirmed that this also affects the Dillo plugin, whereas the LiteHtml plugin still works fine in regards to this in v4.2.0git6.

Note You need to log in before you can comment on or make changes to this bug.