Bug 4744 - oauth2: allow foreigners to open the default browser with request
Summary: oauth2: allow foreigners to open the default browser with request
Status: NEW
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: OAuth2 (show other bugs)
Version: 4.3.0
Hardware: PC All
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2024-01-18 15:07 UTC by olaf
Modified: 2024-05-30 20:49 UTC (History)
0 users

See Also:


Attachments
gtk2-oauth2-allow-foreigners-to-open-the-default-browser-.patch (4.30 KB, patch)
2024-01-18 15:07 UTC, olaf
Details | Diff
master-oauth2-allow-foreigners-to-open-the-default-browser-.patch (4.28 KB, patch)
2024-01-18 15:07 UTC, olaf
Details | Diff

Description olaf 2024-01-18 15:07:03 UTC
Created attachment 2412 [details]
gtk2-oauth2-allow-foreigners-to-open-the-default-browser-.patch

The OAuth2 configuration window has two buttons: one opens the browser with the authorization URL, the other just copies the URL into the X11 clipboards. Both start the listener thread to receive the response from the redirect_url.

Unfortunately, foreigners were only allowed to copy the URL to their clipboard, to paste that URL somewhere in their browsers manually. Change the behavior to be more inclusive: allow everyone to open the default browser right away.
Comment 1 olaf 2024-01-18 15:07:33 UTC
Created attachment 2413 [details]
master-oauth2-allow-foreigners-to-open-the-default-browser-.patch
Comment 2 David Fletcher 2024-05-30 20:49:38 UTC
I don't really understand what problem this aims to solve. What is meant by 
foreigners to open the default browser? Currently during the authorisation process there's a button that will open a default browser. Or you can manually copy/paste and choose whatever browser you want. I've read the supplied diff but I'm not sure what it's trying to achieve.

Note You need to log in before you can comment on or make changes to this bug.