Bug 4832 - Patch for Ayatana indicator support
Summary: Patch for Ayatana indicator support
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: Plugins/Notification (show other bugs)
Version: GIT
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2024-10-19 06:08 UTC by Jan Willamowius
Modified: 2024-11-26 07:51 UTC (History)
0 users

See Also:


Attachments
Patch for an indicator icon that works with current Ubuntu 24.04 (12.08 KB, patch)
2024-10-19 12:20 UTC, Jan Willamowius
Details | Diff
Updated patch (11.49 KB, patch)
2024-10-28 12:14 UTC, Jan Willamowius
Details | Diff
Updated patch with missing files (16.66 KB, patch)
2024-10-28 14:41 UTC, Jan Willamowius
Details | Diff

Description Jan Willamowius 2024-10-19 06:08:57 UTC
I couldn't get any of the notification / systray implementations to
work with current Ubuntu versions. What does work with Ubuntu 24.04 are
Ayatana indicators (that look like regular tray icons to me).

I have added them to the Notfication plugin.
Comment 1 Ricardo Mones 2024-10-19 11:53:13 UTC
Hi Jan, I can't find any patch attached to the bug or URL pointing to one, so I'm a bit confused, please choose one:

a) are you sharing a patch but forgot to add it?
b) are still you working on a patch which will be shared later?
c) other... please explain! :-)

Thanks in advance and best regards!
Comment 2 Jan Willamowius 2024-10-19 12:20:47 UTC
Created attachment 2513 [details]
Patch for an indicator icon that works with current Ubuntu 24.04

Add missing patch file
Comment 3 Paul 2024-10-25 06:58:36 UTC
Thanks for your potential contribution. There are, however, several problems with your patch. Among them:

* The icon shows even when disabled

* The sensivity of the option is wrong. For example, if you disable the icon
  the option becomes insensitive and cannot be re-enabled. (In fact, the option
  doesn't need any sensitivity set, it should always be possible to turn it on
  or off.)

* There are unused variables

When the bugs are fixed we will be happy to include it.
Comment 4 Paul 2024-10-25 08:49:25 UTC
(In reply to Jan Willamowius from comment #0)

> I couldn't get any of the notification / systray implementations to
> work with current Ubuntu versions. What does work with Ubuntu 24.04 are
> Ayatana indicators (that look like regular tray icons to me)

BTW, I don't think you mean Ubuntu (the linux distribution), instead you mean
Gnome (the default desktop enviroment). You are saying that only Ayatana indicators
work with the Gnome desktop.
Comment 5 Jan Willamowius 2024-10-25 09:27:56 UTC
(In reply to Paul from comment #4)
Honestly, I'm not sure which versions or modifications of GNOME the indicators work on or not. Older versions of Ubuntu shipped with GNOME, too and there the existing Claws notifications worked fine. So I tried to be as specific as I can, saying this works on the default Ubuntu 24.04 installation.

Maybe someone more knowledgeable about the versions and compatibilities than me can add info where the Ayatana indicators work and where they don't.

I'll check the issues, you mentioned and will update the patch.
Comment 6 Jan Willamowius 2024-10-28 12:14:34 UTC
Created attachment 2515 [details]
Updated patch

Updated patch: Fixed the show / hide logic, removed sensitivity settings, removed unused variables
Comment 7 Paul 2024-10-28 13:39:46 UTC
Hi,

The latest patch is missing the 2 main files: notification_ayatana_indicator.c and notification_ayatana_indicator.h
Comment 8 Jan Willamowius 2024-10-28 14:41:16 UTC
Created attachment 2516 [details]
Updated patch with missing files
Comment 9 Paul 2024-10-28 16:48:40 UTC
In KDE, when the icon was showing even if disabled the icon would display correctly. Now that it is fixed and only displays when enabled, the space is present but the icon does not show at all. The context menu displays and works, but there is no icon visible.
Comment 10 Jan Willamowius 2024-10-28 18:44:08 UTC
I installed Kubuntu 24.10, but I can't reproduce that issue. When I disable the indicator, it disappears and the icon left to it moves over. No empty "ghost" space, no lingering menu.

But on KDE, the existing systray icon should work, right ?
Comment 11 Paul 2024-11-26 07:51:48 UTC
now in git.

many thanks for your contribution!

Note You need to log in before you can comment on or make changes to this bug.